Update id to match page template #1836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacoords
reviewed
Aug 5, 2022
| ?> | ||
|
|
||
| <div class="wrapper" id="full-width-page-wrapper"> | ||
| <div class="wrapper" id="<?php echo $wrapper_id; // phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped -- ok. ?>"> |
There was a problem hiding this comment.
What's the reasoning for not just using esc_attr() here?
There was a problem hiding this comment.
We know that we will never have to escape the attribute. It's either 'full-width-page-wrapper' or 'no-title-page-wrapper'. Calling esc_attr() just adds a call without any benefit.
Updated the HTML comment |
bacoords
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, adds a page template specific ID for the wrapper in the no-title page template.