Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hover styles and link color from dots in pagination #1838

Merged
merged 1 commit into from Aug 9, 2022

Conversation

IanDelMar
Copy link
Contributor

Description

This PR removes styles hover styles from the "dots elements" in the pagination.

Motivation and Context

By default all non-disabled elements in the pagination with class .page-link that do not represent the current page receive hover styles. Bootstrap default styles apply the link color to the text of the pagination items. This also applies to the elements indicating truncated pages with dots. These elements are not clickable. Having hover styles and link color makes the user expect them to be clickable and hence leads to bad UX.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • (Optional) My change requires a change to the documentation.
  • (Optional) I have updated the documentation accordingly.
  • (Optional) My change requires a change to the translations.
  • (Optional) I have updated the translations accordingly.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • I have read the CONTRIBUTING document.

Related Issues or Roadmap requests

Further comments

@IanDelMar
Copy link
Contributor Author

@bacoords ready for review

@bacoords bacoords merged commit 3a47cd0 into understrap:develop Aug 9, 2022
@IanDelMar IanDelMar deleted the pagination branch August 9, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants