Fix 'Trying to access array offset on value of type bool' in WP 5.0-5.2 #1841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
true
as the second argument toadd_theme_support( 'post-thumbails' )
.Motivation and Context
Prior to version 5.3 calling
add_theme_support( 'post-thumbails' )
without the second argument makes WP try to access the index of a variable with valuetrue
. PHP throws a 'Trying to access array offset on value of type bool' notice. As Understrap currently supports WP versions back to version 5.0 we should fix this.See https://github.com/WordPress/WordPress/blob/d1e96dfce29333740f8a5042e2e760746ede89ea/wp-includes/theme.php#L2340-L2362 (WP 5.2.15) for the code causing the notice and see https://github.com/WordPress/WordPress/blob/6d40400756c0dc14c7f9aac1e60f6a84fc428b3d/wp-includes/theme.php#L2385-L2405 (WP 5.3) for the code fixing the notice.
Types of changes
Checklist:
develop
.develop
.composer cs:check
has passed locally.composer lint:php
has passed locally.Related Issues or Roadmap requests
Further comments