Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
__( '1 Comment', 'understrap' )
and__( '% Comments', 'understrap' )
.__( 'Leave a comment<span class="screen-reader-text"> on %s</span>', 'understrap' )
.Motivation and Context
WP uses the exact same string and provides a translation with better accessibility. See https://github.com/WordPress/WordPress/blob/2f1cac50d34ea42286c89bed28c51ba0b81c17ca/wp-includes/comment-template.php#L1579-L1588. For accessibility reasons we should add a screen reader text to
__( 'Leave a comment', 'understrap' )
as well.Types of changes
Checklist:
develop
.develop
.composer cs:check
has passed locally.composer lint:php
has passed locally.Further comments
For the part with the screen reader text I used translation from WP 6.0.1 for the string "No Comments on %s". See here for Spanish. I also checked the "Leave a comment" part for consistency here.