Update WooCommerce templates #1904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bacoords
reviewed
Sep 29, 2022
| add_filter( 'woocommerce_loop_add_to_cart_args', 'understrap_loop_add_to_cart_args' ); | ||
|
|
||
| // Add markup. | ||
| add_filter( 'woocommerce_loop_add_to_cart_link', 'understrap_loop_add_to_cart_link' ); |
There was a problem hiding this comment.
Can you explain this filter that adds the container around the add to cart button?
|
Also do we still need to modify |
This PR does not solve that issue. |
bacoords
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates some WooCommerce templates and drops one template by using filters instead.
Motivation and Context
Some changes (some from long ago, some more recent changes) have not yet been incorporated into the Understrap WooCommerce templates.
Types of changes
Checklist:
develop.develop.composer cs:checkhas passed locally.composer lint:phphas passed locally.Related Issues or Roadmap requests
Fixes #1903
Further comments
Update msgid: woocommerce/woocommerce@b7c8e3e
Accessibility improvements: woocommerce/woocommerce@bb02983
Use wp_doing_ajax: woocommerce/woocommerce@4f39c25