Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update understrap_kses_title() to not strip WPML flags #1927

Merged
merged 2 commits into from Sep 29, 2022

Conversation

IanDelMar
Copy link
Contributor

Description

Alternative to #1850

Motivation and Context

See #1850

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • I have read the CONTRIBUTING document.

Related Issues or Roadmap requests

Further comments

  • @bacoords what do you think?
  • I cannot replicate the WPML flag issue and therefor cannot test whether this PR resolves the issue.

@bacoords
Copy link
Member

I'll look into this more and compare the two PRs

@bacoords bacoords added this to the 1.3.0 milestone Sep 29, 2022
@IanDelMar
Copy link
Contributor Author

I got it wrong. I was thinking that WPML flags not Polylang flags have a data uri.

@bacoords bacoords merged commit aa9a33a into understrap:develop Sep 29, 2022
@IanDelMar IanDelMar deleted the kses-title-v2 branch September 29, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants