cleans up phpstan errors #1937
Merged
cleans up phpstan errors #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IanDelMar I created this PR to clean up the phpstan errors on the Another idea I'd like to dig into - moving everything under |
howarddc
approved these changes
Oct 5, 2022
|
See szepeviktor/phpstan-wordpress#118. Once this PR gets merged and a new version of szepeviktor/phpstan-wordpress is released, the errors will no longer show up. Until then, I suggest to remove the ignore comments and put the errors in the baseline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should clean up the 4 new PHPStan errors.