Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add since tag for changes from v1.0.0 #1966

Merged
merged 1 commit into from Nov 5, 2022
Merged

Add since tag for changes from v1.0.0 #1966

merged 1 commit into from Nov 5, 2022

Conversation

IanDelMar
Copy link
Contributor

Description

This PR adds since tags to file and function comments for changes in Understrap version 1.0.0, 1.0.1, 1.1.0, 1.2.0.

Motivation and Context

Improve inline documentation.

Types of changes

No code change

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • I have read the CONTRIBUTING document.

@bacoords bacoords merged commit 8d6e4bc into understrap:develop Nov 5, 2022
@IanDelMar IanDelMar deleted the since-v1 branch November 6, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bacoords bacoords bacoords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IanDelMar @bacoords