Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanitize_callback for the container type setting and the navbar type setting #1973

Merged
merged 2 commits into from Nov 5, 2022

Conversation

IanDelMar
Copy link
Contributor

Description

This PR

  • removes the sanitize_callback argument from WP_Customize_Control which does not have such an argument.
  • sets understrap_customize_sanitize_select to be the sanitize_callback when adding the setting.

Motivation and Context

Misplacement of the sanitize_callback => 'understrap_customize_sanitize_select'.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • composer cs:check has passed locally.
  • composer lint:php has passed locally.
  • I have read the CONTRIBUTING document.

@bacoords bacoords merged commit 2636e33 into understrap:develop Nov 5, 2022
@IanDelMar IanDelMar deleted the fix-sanitize-callback branch November 6, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants