Add editor-color-palette-bootstrap4.json #2032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds editor-color-palette-bootstrap4.json which permanently holds the Bootstrap 4 color palette. editor-color-palette.json now permanently holds the Bootstrap 5 color palette.
Fixes the color palette for Bootstrap 5 and most likely increases color related accessibility.
Motivation and Context
See #2028
Types of changes
Breaking/changing the default styles for users who are currently using Bootstrap 5 as they now get the Bootstrap 5 palette instead of the Bootstrap 4 palette.
Checklist:
develop
.develop
.composer phpcs
has passed locally.composer php-lint
has passed locally.composer phpmd
has passed locally.composer phpstan
has passed locally.Related Issues or Roadmap requests
Closes #2028
Further comments
This PR is waiting for bacoords/postcss-understrap-palette-generator#4 to be merged.
TODO:
1. Update postcss-understrap-palette-generator dependency.2. Generate separate JSON files.