Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Babel compile Bootstrap imports #2035

Merged
merged 17 commits into from Oct 10, 2023
Merged

Conversation

IanDelMar
Copy link
Contributor

Description

This PR explicitly sets the Babel presets option in rollup.config.js.

Motivation and Context

Not explicitly setting the presets option results in imports from node_module (like Bootstrap) not being compiled. Now that we're using Bootstrap src files compilation is necessary.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (a code change that neither fixes a bug nor adds a feature)
  • Styling (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Development (changes that affect the build system or external dependencies)
  • Documentation (changes that affect existing inline documentation)

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • (Optional) My change requires a change to the documentation.
  • (Optional) I have updated the documentation accordingly.
  • (Optional) My change requires a change to the translations.
  • (Optional) I have updated the translations accordingly.
  • composer phpcs has passed locally.
  • composer php-lint has passed locally.
  • composer phpmd has passed locally.
  • composer phpstan has passed locally.
  • I have read the CONTRIBUTING document.

Further comments

Alternatively, one could place babel.config.js in the root directory and remove the babel setting in package.json. @bacoords I recommend treating this as a high priority PR.

@bacoords bacoords added this to the Release 1.3.0 milestone Feb 2, 2023
@bacoords bacoords merged commit 00e3a4f into understrap:develop Oct 10, 2023
4 checks passed
@IanDelMar IanDelMar deleted the fix-babel branch October 10, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants