Use understrap_get_screen_reader_class() for a.skip-link #2045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
understrap_get_screen_reader_class()
and uses that function to readd Bootstrap's screen reader text classes toa.skip-link
.Motivation and Context
Adding focusable screen reader text styles to
.skip-link
and removing.sr-only
and.sr-only-focusable
froma.skip link
permanently unhidesa.skip link
for child themes not loading Understrap's theme.css and not including a recent version of assets/understrap/theme/_theme.scss in child-theme.scss. Removing the classes has been a breaking change.Types of changes
Checklist:
develop
.develop
.composer phpcs
has passed locally.composer php-lint
has passed locally.composer phpmd
has passed locally.composer phpstan
has passed locally.Related Issues or Roadmap requests
Fixes #2036
Further comments
@bacoords I suggest to add this to v1.2.2.