Improve readability of sidebar templates #2071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the sidebar active check to the top of the file to increase readability.
Motivation and Context
Returning early reduces complexity and increases readability. In the footerfull case and the statichero case this pattern even save a call to
get_theme_mod( 'understrap_container_type' )
if the corresponding sidebar is not active.Types of changes
Checklist:
develop
.develop
.composer phpcs
has passed locally.composer php-lint
has passed locally.composer phpmd
has passed locally.composer phpstan
has passed locally.Further comments
It's not immediately apparent in the diff but the actual sidebar code has not changed at all.