Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and update WooCommerce templates #2091

Merged
merged 19 commits into from Oct 11, 2023
Merged

Conversation

IanDelMar
Copy link
Contributor

@IanDelMar IanDelMar commented Feb 21, 2023

Description

Updates templates to WC 8.1.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactoring (a code change that neither fixes a bug nor adds a feature)
  • Styling (changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc))
  • Development (changes that affect the build system or external dependencies)
  • Documentation (changes that affect existing inline documentation)

Checklist:

  • I pulled my branch from develop.
  • I am submitting my pull request to develop.
  • I have resolved any conflicts merging this pull request would create.
  • I have checked that there aren't other open Pull Requests for the same update/change.
  • My code follows the code style of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • (Optional) My change requires a change to the documentation.
  • (Optional) I have updated the documentation accordingly.
  • (Optional) My change requires a change to the translations.
  • (Optional) I have updated the translations accordingly.
  • composer phpcs has passed locally.
  • composer php-lint has passed locally.
  • composer phpmd has passed locally.
  • composer phpstan has passed locally.
  • I have read the CONTRIBUTING document.

Related Issues or Roadmap requests

#2115
#2112

Further comments

@IanDelMar IanDelMar changed the title Add WooCommerce 7.4.0 template update Add and update WooCommerce templates Jul 11, 2023
@bacoords
Copy link
Member

bacoords commented Oct 9, 2023

@IanDelMar Do you know why it's not passing the first test? Will pulling in the updates to develop help?

@bacoords bacoords added this to the Release 1.2.3 milestone Oct 9, 2023
@IanDelMar
Copy link
Contributor Author

@bacoords It's caused by the auto commit action. Yes, if you merge develop into this PR all jobs should pass. I tried to fix the problem with the auto commit action. But now the workflow is triggered twice. I have to check that again.

@IanDelMar
Copy link
Contributor Author

I'll fix this PR a bit later

@bacoords bacoords merged commit e13c34d into understrap:develop Oct 11, 2023
4 checks passed
@IanDelMar IanDelMar deleted the woo-7.4 branch October 11, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants