Add understrap_is_bootstrap_v4()
to simplify version checking
#2201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
understrap_is_bootstrap_v4()
: This new function simplifies the process of checking the Bootstrap version utilized by the theme. Instead of directly comparing the theme mod value with 'bootstrap4', developers can now use this concise and readable function, enhancing code maintainability and readability.$label_class
in WooCommerce template: I've addressed an issue in the woocommerce/checkout/form-verify-email.php template where $label_class was incorrectly set to an empty string due to the always truthy evaluation ofget_theme_mod( 'understrap_bootstrap_version', 'bootstrap4' )
. This fix ensures that$label_class
is accurately assigned, improving the visual consistency of the checkout form.Motivation and Context
$label_class
assignment ensures that the WooCommerce form remains visually consistent, enhancing the user experience.Types of changes
Checklist:
develop
.develop
.composer phpcs
has passed locally.composer php-lint
has passed locally.composer phpmd
has passed locally.composer phpstan
has passed locally.Related Issues or Roadmap requests
Further comments