Merge pull request #1288 from carterkozak/UNDERTOW-2017

UNDERTOW-2017: HttpRequestConduit state is correctly maintained
undertow-io · Feb 6, 2022 · 19a17fe · 19a17fe
2 parents c5298bd + 3491181
commit 19a17fe
Showing 1 changed file with 0 additions and 26 deletions.
diff --git a/core/src/main/java/io/undertow/client/http/HttpRequestConduit.java b/core/src/main/java/io/undertow/client/http/HttpRequestConduit.java
@@ -100,12 +100,7 @@ private int processWrite(int state, final ByteBuffer userData) throws IOExceptio
         }
         ClientRequest request = this.request;
         ByteBuffer buffer = pooledBuffer.getBuffer();
-        Iterator<HttpString> nameIterator = this.nameIterator;
-        Iterator<String> valueIterator = this.valueIterator;
-        int charIndex = this.charIndex;
         int length;
-        String string = this.string;
-        HttpString headerName = this.headerName;
         int res;
         // BUFFER IS FLIPPED COMING IN
         if (state != STATE_START && buffer.hasRemaining()) {
@@ -189,11 +184,6 @@ private int processWrite(int state, final ByteBuffer userData) throws IOExceptio
                             do {
                                 res = next.write(buffer);
                                 if (res == 0) {
-                                    this.string = string;
-                                    this.headerName = headerName;
-                                    this.charIndex = charIndex;
-                                    this.valueIterator = valueIterator;
-                                    this.nameIterator = nameIterator;
                                     log.trace("Continuation");
                                     return STATE_HDR_NAME;
                                 }
@@ -210,11 +200,6 @@ private int processWrite(int state, final ByteBuffer userData) throws IOExceptio
                             res = next.write(buffer);
                             if (res == 0) {
                                 log.trace("Continuation");
-                                this.string = string;
-                                this.headerName = headerName;
-                                this.charIndex = charIndex;
-                                this.valueIterator = valueIterator;
-                                this.nameIterator = nameIterator;
                                 return STATE_HDR_D;
                             }
                         } while (buffer.hasRemaining());
@@ -230,11 +215,6 @@ private int processWrite(int state, final ByteBuffer userData) throws IOExceptio
                             res = next.write(buffer);
                             if (res == 0) {
                                 log.trace("Continuation");
-                                this.string = string;
-                                this.headerName = headerName;
-                                this.charIndex = charIndex;
-                                this.valueIterator = valueIterator;
-                                this.nameIterator = nameIterator;
                                 return STATE_HDR_DS;
                             }
                         } while (buffer.hasRemaining());
@@ -260,11 +240,6 @@ private int processWrite(int state, final ByteBuffer userData) throws IOExceptio
                             do {
                                 res = next.write(buffer);
                                 if (res == 0) {
-                                    this.string = string;
-                                    this.headerName = headerName;
-                                    this.charIndex = charIndex;
-                                    this.valueIterator = valueIterator;
-                                    this.nameIterator = nameIterator;
                                     log.trace("Continuation");
                                     return STATE_HDR_VAL;
                                 }
@@ -467,7 +442,6 @@ private int processWrite(int state, final ByteBuffer userData) throws IOExceptio
                                 if (res == 0) {
                                     log.trace("Continuation");
                                     this.charIndex = i;
-                                    this.string = string;
                                     this.state = STATE_URL;
                                     return STATE_URL;
                                 }