[UNDERTOW-1834] Fix for IBM JDK and HTTP2/ALPN. #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, I went through the failed tests and I don't think they are related to changes in this PR. |
fl4via
added
bug fix
|
@jstourac I'll carefully review this in light of what has been said in the Jira. |
There is a difference in IBM JDK TLS ciphersuite names versus their Oracle JDK counterparts, see e.g. [1]. This discrepancy causes issue in usage of HTTP2 with IBM JDK since we check enabled ciphersuite based on the name in Oracle JDK variant only. So if there is an incomming connection from client that offers IBM names of the ciphersuite, we simply fail to use ALPN and HTTP2 with it consequently. This change should fix such issue. [1] https://www.ibm.com/support/knowledgecenter/SSFKSJ_9.0.0/com.ibm.mq.dev.doc/q113210_.htm
|
just rebased, no code changes |
ropalka
added
next release
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/UNDERTOW-1834
There is a difference in IBM JDK TLS ciphersuite names versus their
Oracle JDK counterparts, see e.g. [1].
This discrepancy causes issue in usage of HTTP2 with IBM JDK since
we check enabled ciphersuite based on the name in Oracle JDK variant
only. So if there is an incomming connection from client that offers
IBM names of the ciphersuite, we simply fail to use ALPN and HTTP2
with it consequently.
This change should fix such issue.
[1] https://www.ibm.com/support/knowledgecenter/SSFKSJ_9.0.0/com.ibm.mq.dev.doc/q113210_.htm