Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1879] Utilize o.w.common.Assert class for Null-Checks #1089

Merged
merged 1 commit into from Oct 5, 2021
Merged

[UNDERTOW-1879] Utilize o.w.common.Assert class for Null-Checks #1089

merged 1 commit into from Oct 5, 2021

Conversation

boris-unckel
Copy link
Contributor

@boris-unckel boris-unckel force-pushed the UNDERTOW-1879_utilize_assert_for_nullchecks branch 2 times, most recently from 7b8f001 to 9f18201 Compare April 15, 2021 08:50
@boris-unckel
Copy link
Contributor Author

@ropalka @fl4via Could you please have a look at this? I don't think the failed checks are related, because other pulls fail with the same errors. Thanks in advance for any feedback or approval/merge.

@boris-unckel boris-unckel force-pushed the UNDERTOW-1879_utilize_assert_for_nullchecks branch from 9f18201 to 19b529a Compare June 13, 2021 08:42
@boris-unckel
Copy link
Contributor Author

@fl4via Could you please give this PR a chance and review it? I have rebased the PR, now the CI is not available and the retest is open.

@boris-unckel boris-unckel force-pushed the UNDERTOW-1879_utilize_assert_for_nullchecks branch from 19b529a to 5046fed Compare July 16, 2021 09:22
@boris-unckel boris-unckel changed the title [UNDERTOW-1879] Utilize new Assert class for Null-Checks [UNDERTOW-1879] Utilize o.w.common.Assert class for Null-Checks Aug 21, 2021
@boris-unckel boris-unckel force-pushed the UNDERTOW-1879_utilize_assert_for_nullchecks branch from 5046fed to 2edde24 Compare August 21, 2021 21:09
@boris-unckel boris-unckel force-pushed the UNDERTOW-1879_utilize_assert_for_nullchecks branch from 2edde24 to 56b663b Compare October 2, 2021 13:00
@boris-unckel
Copy link
Contributor Author

Hello @fl4via could you review and approve this PR, please? It's rebased on master, tests passed.

@ropalka ropalka added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) labels Oct 5, 2021
@ropalka ropalka merged commit 42561a7 into undertow-io:master Oct 5, 2021
@boris-unckel boris-unckel deleted the UNDERTOW-1879_utilize_assert_for_nullchecks branch October 5, 2021 07:35
@fl4via
Copy link
Member

fl4via commented Nov 19, 2021 •
edited

@boris-unckel and @ropalka , because of the changes in the dependencies of undertow module in WF and given 2.2.13.Final is a minor release, I'm reverting this change and we will submit it again for 2.3.0.Final after hearing back feedback from @bstansberry on the impact this will have in WF. Please see more info here: https://issues.redhat.com/browse/UNDERTOW-1879?focusedCommentId=19344919&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-19344919

FYI, as soon as we have merged all PRs in the line, we will have a new policy where master does not contain minor releases anymore, and this will make life easier. For now, the only solution is reverting and resubmitting the PR. I appreciate your understanding @boris-unckel and I also appreciate your contribution to the Undertow project!

@fl4via fl4via mentioned this pull request Nov 19, 2021
Merged
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Nov 20, 2021
@boris-unckel boris-unckel mentioned this pull request Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ropalka ropalka ropalka approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code
Projects
None yet
Milestone
No milestone
3 participants
@boris-unckel @fl4via @ropalka