[UNDERTOW-1359] - fix concurrent change/access to buffer #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
added
bug fix
fl4via
added
duplicate
|
Because synchronizing is not the solution, I'm taking the freedom to close this PR in favor of the other, but I'm suggesting a different change altogether. You might want to just close that PR and submit a new one, @baranowb , so that history does not get lost along the way in case we need to revisit the bug and the proposed fixes |
fl4via
removed
the
under verification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-1359
Needs perf check/comparison. If impact is too big, most likely some hacky way to handle concurrent access( retain value in local var and work on it + trap exceptions thrown and abort ops if those happen?)