[UNDERTOW-1917] Logic in try/finally blocks hides exceptions #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The solution is inspired by @jfdenise proposal, already working in WFCore: wildfly/wildfly-core#4615 |
|
@fl4via Hello Flavia, I have prepared this PR to fix a bug regarding exception suppressing. Please, could you review and advise what is needed to polish it? After everything is prepared for the actual version I can provide the backport also, if you want to have this fixed for older versions, too. |
fl4via
approved these changes
Sep 9, 2021
fl4via
added
the
waiting peer review
fl4via
force-pushed
the
UNDERTOW-1917_try_finally_ex
branch
from
43cf0c0
to
18f2dbf
Compare
fl4via
added
waiting CI check
ropalka
requested changes
Sep 10, 2021
fl4via
added
next release
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/UNDERTOW-1917