Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-1962] Add a StopServerWithExternalWorkerUtils, and make sur… #1244

Merged
merged 3 commits into from Sep 27, 2021

Conversation

fl4via
Copy link
Member

@fl4via fl4via commented Sep 14, 2021

…e that the tests are waiting for servers to completely stop before starting a new one at the same address

Jira: https://issues.redhat.com/browse/UNDERTOW-1962

@fl4via fl4via added enhancement Enhances existing behaviour or code waiting CI check Ready to be merged but waiting for CI check labels Sep 14, 2021
@fl4via fl4via force-pushed the UNDERTOW-1962 branch 2 times, most recently from f4be343 to 6500e40 Compare September 14, 2021 02:05
@fl4via fl4via changed the title [UNDERTOW-1962] ADd a StopServerWithExternalWorkerUtils, and make sur… [UNDERTOW-1962] Add a StopServerWithExternalWorkerUtils, and make sur… Sep 14, 2021
@fl4via fl4via added the failed CI Introduced new regession(s) during CI check label Sep 16, 2021
…tests, and make sure tests are waiting for servers to completely stop before starting a new one at the same address
@fl4via fl4via removed the failed CI Introduced new regession(s) during CI check label Sep 20, 2021
@fl4via
Copy link
Member Author

fl4via commented Sep 20, 2021

Assuming we don't have any more address already in use after this run, I'll replace the latest commit by a new utils, probably called StopServerUtils

@fl4via fl4via added the next release This PR will be merged before next release or has already been merged (for payload double check) label Sep 27, 2021
@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Sep 27, 2021
@fl4via fl4via merged commit 08e48fc into undertow-io:master Sep 27, 2021
@fl4via fl4via deleted the UNDERTOW-1962 branch September 27, 2021 10:51
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances existing behaviour or code
Projects
None yet
1 participant