Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-1848] SimpleSSLTestCase fails on Windows #1298

Merged
merged 1 commit into from Feb 16, 2022

Conversation

rmartinc
Copy link
Contributor

Issue: https://issues.redhat.com/browse/UNDERTOW-1848

Changes in the test:

  • Reduce the load depending the #CPU in the box. The concurrency is set to #CPU*8 up to 32 (before it was always 32 threads). The idea is reducing the number of simultaneous requests when the box has less than 4 CPUs to not stress too much.
  • The SO timeout of the socket has been increased from 5s to 60s (exception java.net.SocketTimeoutException: Read timed out).
  • The total await time was changed from fixed 70s to a while that waits for 10s and counts processed requests. The test stops if failed or if in that period no requests were processed. This way there is no hard time limit.

I have tested the class a lot of times in my VM and no failures even with only 1CPU assigned (which takes 3-5 minutes in each test). But who knows... Let's see if this is enough for the CI...

@ropalka ropalka added next release This PR will be merged before next release or has already been merged (for payload double check) bug fix Contains bug fix(es) labels Feb 11, 2022
@fl4via fl4via merged commit 7133a92 into undertow-io:master Feb 16, 2022
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Contains bug fix(es)
Projects
None yet
3 participants