[UNDERTOW-2027] Spurious buffer leak error in the test-suite (HttpClientTestCase.testReadTimeout) #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entTestCase.testReadTimeout)
fl4via
approved these changes
Mar 11, 2022
fl4via
added
bug fix
|
I'm marking this as a bug fix as well because of the resumeReads in ReadTimeoutStreamSourceConduit. |
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2027
AFAICT there is no real leak in
HttpClientTestCase.testReadTimeout. The problem is with the TS. Two problems fixed in this PR related to that test:resumeReadsif not previously set. Added a new testtestReadTimeoutAtInitwhich forces the timeout before writing anything back to the client.isEmptyin the set. The same local variable is always used to avoid that random buffer allocations triggers spurious errors. This took me a lot of time. 😄Thanks!