[UNDERTOW-2097] DMI_RANDOM_USED_ONLY_ONCE error reported by spotbugs #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's try to reuse instance of `SecureRandom` class when possible. This change is attempt to fix error identified by SpotBugs plugin and described in [1]. [1] https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#dmi-random-object-created-and-used-only-once-dmi-random-used-only-once
|
just rebased against |
|
Failed tests on JDK17 seem to be the very same as are in other PRs so I suppose they are not tied with my changes here. |
fl4via
added
enhancement
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's try to reuse instance of
SecureRandomclass when possible. Thischange is attempt to fix error identified by SpotBugs plugin and
described in [1].
[1] https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#dmi-random-object-created-and-used-only-once-dmi-random-used-only-once
https://issues.redhat.com/browse/UNDERTOW-2097