New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UNDERTOW-2122] Javax imports in servlet tests #1344
Conversation
I have changed my main. I discovered the reason is |
pom.xml
Outdated
@@ -185,7 +185,6 @@ | |||
<configuration> | |||
<!-- fork is needed so compiler args can be used --> | |||
<fork>true</fork> | |||
<failOnError>false</failOnError> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a reason why this is set to false. When running all the Undertow tests (like, in your machine) we want to be able to view all failures, and not have the intermittent ones preventing you from seeing, say, a new failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I'm going back to put failIfNoTests to true in servlet, core and websockets folders to give a failure when something weird happens. Give me some minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's done! Now the surefire plugin fails in the three sub-projects if there are no tests. If there is some error at compilation and the tests are not generated the maven run fails. With this I expect that we will see something strange (tests failures or no test executed) when there are compilation errors.
Thanks!
Issue: https://issues.redhat.com/browse/UNDERTOW-2122
There are javax imports (instead of jakarta) that are creating issues in master. I have fixed that and also added
failIfNoTests
totrue
in the main poms because the error was undetected because of that. If you prefer to not add the last part just let me know.@ropalka @fl4via Please review this when you have time. This is stopping my other PRs. 馃槃
Thanks!