Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UNDERTOW-2122] Javax imports in servlet tests #1344

Merged
merged 1 commit into from Jul 13, 2022

Conversation

rmartinc
Copy link
Contributor

Issue: https://issues.redhat.com/browse/UNDERTOW-2122

There are javax imports (instead of jakarta) that are creating issues in master. I have fixed that and also added failIfNoTests to true in the main poms because the error was undetected because of that. If you prefer to not add the last part just let me know.

@ropalka @fl4via Please review this when you have time. This is stopping my other PRs. 馃槃

Thanks!

@rmartinc
Copy link
Contributor Author

I have changed my main. I discovered the reason is failOnError is false in pom.xml. It seems that it was done long ago (this commit) but better to go revert to the default value and fail if there are compilation errors.

pom.xml Outdated
@@ -185,7 +185,6 @@
<configuration>
<!-- fork is needed so compiler args can be used -->
<fork>true</fork>
<failOnError>false</failOnError>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a reason why this is set to false. When running all the Undertow tests (like, in your machine) we want to be able to view all failures, and not have the intermittent ones preventing you from seeing, say, a new failure.

Copy link
Contributor Author

@rmartinc rmartinc Jul 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I'm going back to put failIfNoTests to true in servlet, core and websockets folders to give a failure when something weird happens. Give me some minutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done! Now the surefire plugin fails in the three sub-projects if there are no tests. If there is some error at compilation and the tests are not generated the maven run fails. With this I expect that we will see something strange (tests failures or no test executed) when there are compilation errors.

Thanks!

@fl4via fl4via added bug fix Contains bug fix(es) waiting PR update Awaiting PR update(s) from contributor before merging labels Jul 12, 2022
@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) and removed waiting PR update Awaiting PR update(s) from contributor before merging labels Jul 13, 2022
@fl4via fl4via merged commit ccb35dd into undertow-io:master Jul 13, 2022
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Contains bug fix(es)
Projects
None yet
2 participants