[UNDERTOW-1818] AbstractServletInputStreamTestCase.runTestParallel fails with bytes out of order #1384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-1818
There are different changes in the PR although the former is the main one (the rest fixes minor issues in the same
AbstractServletInputStreamTestCase
test):Connectors
class. As the method is calledungetRequestBytes
the order is directly changed. If we identify that something needs to insert real new data at the current point in the exchange (not data that was read before and is push back to be read again) another method can be created with the previous order. I think that all the callers are using the re-read / push-back idea.In my envs (windows-2016 and linux-fedora) the
ServletInputStreamRequestBufferingTestCase
was executed with-P proxy
option 50 times without issues. Let's see how the tests go.