[UNDERTOW-2241][UNDERTOW-2247][UNDERTOW-2248] Handle write timeout properly so no chunk errors occur #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
changed the title
fl4via
added
bug fix
fl4via
force-pushed
the
UNDERTOW-2241_2247_2248_master
branch
4 times, most recently
from
3c32a4a
to
03b4de4
Compare
fl4via
added
waiting PR update
|
This failed Windows CI. I'll have to do an investigation of the reason for the failure. |
fl4via
force-pushed
the
UNDERTOW-2241_2247_2248_master
branch
6 times, most recently
from
3a2b7fe
to
c4cd8da
Compare
fl4via
removed
the
waiting peer review
|
Everything indicates the failure in the fix UNDERTOW-2247 is not fully correct. The failure in Windows is a race condition and it requires further work. I'll get back to this after my PTO, on May. |
|
I'm closing for now. Will reopen when I get back to it. |
Signed-off-by: Flavia Rainone <frainone@redhat.com>
…and clear the allocated buffer to prevent NPEs when ClosedChannelExceptions and broken pipe SocketExceptions occur. Those NPEs can occur at the points where the buffer is closed and it is already null because the buffer was cleared by an inner recursive call as an attempt to deal with the exception. The broken pipe can occur when a browser tab is closed during the response writing process. Signed-off-by: Flavia Rainone <frainone@redhat.com>
…reset expireTime to -1, disabling future checks for write timeout at timeoutCommand runnable Signed-off-by: Flavia Rainone <frainone@redhat.com>
…ore closing the connection to give a chance to outer channels wrap up. At ChunkedStreamSinkConduit create the last chunk and attempt to flush before truncating writes. Signed-off-by: Flavia Rainone <frainone@redhat.com>
fl4via
force-pushed
the
UNDERTOW-2241_2247_2248_master
branch
2 times, most recently
from
164b176
to
d6d724a
Compare
…ring and, instead, just fail the test if there is no header Signed-off-by: Flavia Rainone <frainone@redhat.com>
…s failed on unrelated PR CIs we know it is a preexisting intermitent failure Signed-off-by: Flavia Rainone <frainone@redhat.com>
fl4via
force-pushed
the
UNDERTOW-2241_2247_2248_master
branch
from
d6d724a
to
177dd0e
Compare
fl4via
added
next release
|
Something odd happened wiht this PR that, even after 10 minutes of having pushed my branch, the PR was not updated, but I could see the branch was updated by following the link from the PR page to the branch. |
fl4via
added
duplicate
|
The new PR is #1489 |
|
I had to recreate a new PR for the same reason :-( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jiras:
https://issues.redhat.com/browse/UNDERTOW-2241
https://issues.redhat.com/browse/UNDERTOW-2247
https://issues.redhat.com/browse/UNDERTOW-2248
2.2.x backport PR: #1450