[UNDERTOW-2216] fix resource serving via predicates + test #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
requested changes
Apr 23, 2023
| @@ -90,7 +94,7 @@ public static boolean sendRequestedBlobs(HttpServerExchange exchange) { | |||
| return false; | |||
| } | |||
|
|
|||
| public static StringBuilder renderDirectoryListing(String path, Resource resource) { | |||
| public static StringBuilder renderDirectoryListing(final HttpServerExchange exchange, String path, final Resource resource) { | |||
There was a problem hiding this comment.
@baranowb can the original method be deprecated with an attribute marking it for removal on 2.4.0.Final?
There was a problem hiding this comment.
@fl4via yes, however, the question is this fix required, given that more or less this can be achieved with some URL rewriting?
fl4via
added
bug fix
fl4via
approved these changes
Jun 6, 2023
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-2216
2.2.x PR: #1484