HttpClientConnection catches failures more broadly #547
Conversation
|
This change is a bit paranoid, feel free to close out if you think the problem is likely elsewhere. |
|
Windows Build 2168 outcome was FAILURE using a merge of c5790bb |
| private HttpClientExchange currentRequest; | ||
| private HttpResponseBuilder pendingResponse; | ||
| private volatile HttpClientExchange currentRequest; | ||
| private volatile HttpResponseBuilder pendingResponse; |
There was a problem hiding this comment.
Why the volatile? This client is not designed to be thread safe, and should old be used from the IO thread that is tied to the connection.
There was a problem hiding this comment.
Was paranoia. Fixed.
In some (likely failure) cases I've noticed the undertow client fails to execute any ClientCallback methods. I've noticed NPEs in the the logs from SslConduit.doUnwrap, so it's possible this is caused by UNDERTOW-1156.
carterkozak
force-pushed
the
http_client_connection_safety
branch
from
c5790bb
to
640e3ce
Compare
|
Windows Build 2169 outcome was FAILURE using a merge of 640e3ce |
|
Once 1.4.19.Final has published I'll run my test suite against that and report whether or not the hang is fixed. |
|
Still having requests fail to hit the callback on |
|
Added a close setter on checkout which triggers a callback as well, but that doesn't seem to do it either. For context, I've set up timers on my connections which kill the request after ten minutes if nothing has happened. The entirety of my request data is sent, but the response callback is never called. |
|
Do you have any information on which exceptions are being thrown from these methods? |
|
@stuartwdouglas Unfortunately I've not been able to get any logging around the cause |
|
@stuartwdouglas After some digging it appears that the hang occurs (at very low frequency) when clients attempt to connect to servers that are in the process of starting up. Likely some unhandled failure when unexpected data is received. |
In some (likely failure) cases I've noticed the undertow client
fails to execute any ClientCallback methods.
I've noticed NPEs in the the logs from SslConduit.doUnwrap, so
it's possible this is caused by UNDERTOW-1156.