UNDERTOW-1195 correct value of FLUSH_PACKET_STRING in the mod_cluster MCMP implementation #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@stuartwdouglas can you take a quick look at this pull request? thanks in advance! |
|
This is ok to test |
|
Both PR's look good to me. Would it be possible for you to file a JIRA at https://issues.jboss.org/browse/UNDERTOW and update the commit messages to reference the JIRA? Thanks, |
|
Windows Build 2212 outcome was FAILURE using a merge of 4695ed3 |
… MCMP implementation The value of FLUSH_PACKET_STRING in the mod_cluster MCMP implementation should be set to "flushpackets", not "flushpacket".
frapex
changed the title
|
@stuartwdouglas JIRA issue added, commit message updated. |
|
Windows Build 2213 outcome was FAILURE using a merge of 99c33c1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of FLUSH_PACKET_STRING in the mod_cluster MCMP implementation
should be set to "flushpackets", not "flushpacket".
The error can be reproduced by configuring the mod_cluster subsystem with property flush-packets set to true.
Apache httpd mod_cluster-1.3.7 accepts the node. Undertow mod_cluster implementation produces an error:
ERROR: UT005043: Error in processing MCMP commands: Type:SYNTAX, Mess: SYNTAX: Invalid field flushpackets in message
This fix should be applied to all active branches.