Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP/2.0 receiver doesn't respect UndertowOptions.DECODE_URL #678

Merged
merged 1 commit into from Oct 9, 2018

Conversation

neowu
Copy link
Contributor

@neowu neowu commented Oct 6, 2018

with UndertowOptions.DECODE_URL = false, it will always try to decode path if contains "%", and will result in NullPointerException (by io.undertow.util.URLUtils.decode)

due to io.undertow.server.protocol.http2.Http2ReceiveListener.encoding will be null
if UndertowOptions.DECODE_URL = false

with UndertowOptions.DECODE_URL = false, it will always try to decode path if contains "%", and will result in NullPointerException due to encoding param will be null in that condition
@undertow-pull-request
Copy link

Can one of the admins verify this patch?

@stuartwdouglas
Copy link
Contributor

This is ok to test

@undertow-pull-request
Copy link

Linux Build 2820 outcome was UNKNOWN using a merge of f435802
Summary: Canceled (Error while applying patch; cannot find commit 0e318de in the git://github.com/undertow-io/undertow.git repository, possible reason: refs/pull/678/merge branch was updated and the commit selected for the bui... Build time: 00:00:11

@undertow-pull-request
Copy link

Windows Build 2568 outcome was UNKNOWN using a merge of f435802
Summary: Canceled (Error while applying patch; cannot find commit 0e318de in the git://github.com/undertow-io/undertow.git repository, possible reason: refs/pull/678/merge branch was updated and the commit selected for the bui... Build time: 00:00:12

@neowu
Copy link
Contributor Author

neowu commented Oct 8, 2018

Hi,
The checks failed, is there anything needs to be done on my side?

@undertow-pull-request
Copy link

Windows Build 2570 outcome was FAILURE using a merge of f435802
Summary: Error while applying patch Build time: 00:00:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants