Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Included getUnsafe in try/catch to make it work with Java 11+ #728

Merged
merged 1 commit into from Apr 3, 2019
Merged

Included getUnsafe in try/catch to make it work with Java 11+ #728

merged 1 commit into from Apr 3, 2019

Conversation

smironov
Copy link
Contributor

@smironov smironov commented Feb 25, 2019 •
edited

On Java 11.0.2 there was an exception during Unsafe retrieval.
With this patch, there is still exception printed: UndertowLogger.ROOT_LOGGER.directBufferDeallocatorInitializationFailed(t);
but supported flag is set to false and everything works as intended.

java.lang.ExceptionInInitializerError: null at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool.queueIfUnderMax(DefaultByteBufferPool.java:209) at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool.freeInternal(DefaultByteBufferPool.java:201) at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool.access$200(DefaultByteBufferPool.java:40) at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool$DefaultPooledBuffer.close(DefaultByteBufferPool.java:271) at undertow.core@2.0.19.Final/io.undertow.protocols.ssl.SslConduit.doUnwrap(SslConduit.java:843) at undertow.core@2.0.19.Final/io.undertow.protocols.ssl.SslConduit.read(SslConduit.java:567) at xnio.api@3.3.8.Final/org.xnio.conduits.AbstractStreamSourceConduit.read(AbstractStreamSourceConduit.java:51) at undertow.core@2.0.19.Final/io.undertow.conduits.ReadDataStreamSourceConduit.read(ReadDataStreamSourceConduit.java:67) at undertow.core@2.0.19.Final/io.undertow.conduits.FixedLengthStreamSourceConduit.read(FixedLengthStreamSourceConduit.java:244) at xnio.api@3.3.8.Final/org.xnio.conduits.ConduitStreamSourceChannel.read(ConduitStreamSourceChannel.java:127) at undertow.core@2.0.19.Final/io.undertow.channels.DetachableStreamSourceChannel.read(DetachableStreamSourceChannel.java:209) at undertow.core@2.0.19.Final/io.undertow.server.HttpServerExchange$ReadDispatchChannel.read(HttpServerExchange.java:2341) at undertow.core@2.0.19.Final/io.undertow.server.handlers.form.FormEncodedDataDefinition$FormEncodedDataParser.doParse(FormEncodedDataDefinition.java:134) at undertow.core@2.0.19.Final/io.undertow.server.handlers.form.FormEncodedDataDefinition$FormEncodedDataParser.parseBlocking(FormEncodedDataDefinition.java:252) at ... undertow.core@2.0.19.Final/io.undertow.server.Connectors.executeRootHandler(Connectors.java:364) at undertow.core@2.0.19.Final/io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834) Caused by: java.lang.RuntimeException: JDK did not allow accessing unsafe at undertow.core@2.0.19.Final/io.undertow.server.DirectByteBufferDeallocator.getUnsafe0(DirectByteBufferDeallocator.java:106) at undertow.core@2.0.19.Final/io.undertow.server.DirectByteBufferDeallocator.getUnsafe(DirectByteBufferDeallocator.java:97) at undertow.core@2.0.19.Final/io.undertow.server.DirectByteBufferDeallocator.<clinit>(DirectByteBufferDeallocator.java:46) ... 20 common frames omitted Caused by: java.lang.NoClassDefFoundError: sun/misc/Unsafe at undertow.core@2.0.19.Final/io.undertow.server.DirectByteBufferDeallocator.getUnsafe0(DirectByteBufferDeallocator.java:102) ... 22 common frames omitted Caused by: java.lang.ClassNotFoundException: sun.misc.Unsafe at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) ... 23 common frames omitted 2019-02-25T14:54:53.060 ERROR [XNIO-1 task-8] io.undertow.request - UT005071: Undertow request failed java.lang.NoClassDefFoundError: Could not initialize class io.undertow.server.DirectByteBufferDeallocator at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool.queueIfUnderMax(DefaultByteBufferPool.java:209) at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool.freeInternal(DefaultByteBufferPool.java:201) at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool.access$200(DefaultByteBufferPool.java:40) at undertow.core@2.0.19.Final/io.undertow.server.DefaultByteBufferPool$DefaultPooledBuffer.close(DefaultByteBufferPool.java:271) at undertow.core@2.0.19.Final/io.undertow.protocols.ssl.SslConduit.doUnwrap(SslConduit.java:843) at undertow.core@2.0.19.Final/io.undertow.protocols.ssl.SslConduit.read(SslConduit.java:567) at xnio.api@3.3.8.Final/org.xnio.conduits.AbstractStreamSourceConduit.read(AbstractStreamSourceConduit.java:51) at undertow.core@2.0.19.Final/io.undertow.conduits.ReadDataStreamSourceConduit.read(ReadDataStreamSourceConduit.java:67) at undertow.core@2.0.19.Final/io.undertow.conduits.FixedLengthStreamSourceConduit.read(FixedLengthStreamSourceConduit.java:244) at xnio.api@3.3.8.Final/org.xnio.conduits.ConduitStreamSourceChannel.read(ConduitStreamSourceChannel.java:127) at undertow.core@2.0.19.Final/io.undertow.channels.DetachableStreamSourceChannel.read(DetachableStreamSourceChannel.java:209) at undertow.core@2.0.19.Final/io.undertow.server.HttpServerExchange$ReadDispatchChannel.read(HttpServerExchange.java:2341) at undertow.core@2.0.19.Final/io.undertow.server.handlers.form.FormEncodedDataDefinition$FormEncodedDataParser.doParse(FormEncodedDataDefinition.java:134) at undertow.core@2.0.19.Final/io.undertow.server.handlers.form.FormEncodedDataDefinition$FormEncodedDataParser.parseBlocking(FormEncodedDataDefinition.java:252) at ... at undertow.core@2.0.19.Final/io.undertow.server.Connectors.executeRootHandler(Connectors.java:364) at undertow.core@2.0.19.Final/io.undertow.server.HttpServerExchange$1.run(HttpServerExchange.java:830) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:834)

@undertow-pull-request
Copy link

Can one of the admins verify this patch?

@colesico
Copy link

colesico commented Mar 7, 2019 •
edited

pls admit this patch, have a real issue with java 11  

@ctomc
Copy link
Contributor

ctomc commented Mar 12, 2019

this is ok to test

@undertow-pull-request
Copy link

Linux Build 2955 outcome was FAILURE using a merge of ca5896b
Summary: Tests failed: 1 (1 new), passed: 3460, ignored: 631 Build time: 00:52:58

Failed tests

io.undertow.server.handlers.proxy.LoadBalancerConnectionPoolingTestCase.shouldReduceConnectionPool: java.lang.AssertionError: expected:<0> but was:<1>
	at io.undertow.server.handlers.proxy.LoadBalancerConnectionPoolingTestCase.shouldReduceConnectionPool(LoadBalancerConnectionPoolingTestCase.java:132)
	at io.undertow.testutils.DefaultServer.runChild(DefaultServer.java:524)
	at io.undertow.testutils.DefaultServer.runChild(DefaultServer.java:104)
	at io.undertow.testutils.DefaultServer.run(DefaultServer.java:297)
------- Stdout: -------
added io.undertow.server.protocol.http.HttpServerConnection@17523c7
------- Stderr: -------
07:54:52,034 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,034 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:566> Sent request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target 127.0.0.1 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,035 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:87> request terminated for request to localhost/127.0.0.1:7777 /
07:54:52,040 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:691> Received response ClientResponse{responseHeaders={Connection=[keep-alive], Content-Length=[0], Date=[Tue, 12 Mar 2019 14:53:22 GMT]}, responseCode=200, status='OK', protocol=HTTP/1.1} for request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,041 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:103> response terminated for request to localhost/127.0.0.1:7777 /
07:54:52,041 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientConnection] <HttpClientConnection.java:479> exchange complete in connection to localhost/127.0.0.1:7777
07:54:52,044 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,045 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:566> Sent request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target 127.0.0.1 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,045 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:87> request terminated for request to localhost/127.0.0.1:7777 /
07:54:52,046 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:691> Received response ClientResponse{responseHeaders={Connection=[keep-alive], Content-Length=[0], Date=[Tue, 12 Mar 2019 14:53:22 GMT]}, responseCode=200, status='OK', protocol=HTTP/1.1} for request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,046 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:103> response terminated for request to localhost/127.0.0.1:7777 /
07:54:52,046 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientConnection] <HttpClientConnection.java:479> exchange complete in connection to localhost/127.0.0.1:7777
07:54:52,047 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,047 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:566> Sent request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target 127.0.0.1 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,047 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:87> request terminated for request to localhost/127.0.0.1:7777 /
07:54:52,048 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:691> Received response ClientResponse{responseHeaders={Connection=[keep-alive], Content-Length=[0], Date=[Tue, 12 Mar 2019 14:53:22 GMT]}, responseCode=200, status='OK', protocol=HTTP/1.1} for request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,048 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:103> response terminated for request to localhost/127.0.0.1:7777 /
07:54:52,049 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientConnection] <HttpClientConnection.java:479> exchange complete in connection to localhost/127.0.0.1:7777
07:54:52,049 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,049 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:566> Sent request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target 127.0.0.1 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,049 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:87> request terminated for request to localhost/127.0.0.1:7777 /
07:54:52,050 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:691> Received response ClientResponse{responseHeaders={Connection=[keep-alive], Content-Length=[0], Date=[Tue, 12 Mar 2019 14:53:22 GMT]}, responseCode=200, status='OK', protocol=HTTP/1.1} for request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,050 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:103> response terminated for request to localhost/127.0.0.1:7777 /
07:54:52,051 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientConnection] <HttpClientConnection.java:479> exchange complete in connection to localhost/127.0.0.1:7777
07:54:52,051 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,051 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:566> Sent request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target 127.0.0.1 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,051 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:87> request terminated for request to localhost/127.0.0.1:7777 /
07:54:52,053 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:691> Received response ClientResponse{responseHeaders={Connection=[keep-alive], Content-Length=[0], Date=[Tue, 12 Mar 2019 14:53:22 GMT]}, responseCode=200, status='OK', protocol=HTTP/1.1} for request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,053 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:103> response terminated for request to localhost/127.0.0.1:7777 /
07:54:52,053 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientConnection] <HttpClientConnection.java:479> exchange complete in connection to localhost/127.0.0.1:7777
07:54:52,053 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,054 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:566> Sent request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target 127.0.0.1 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,054 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:87> request terminated for request to localhost/127.0.0.1:7777 /
07:54:52,055 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:691> Received response ClientResponse{responseHeaders={Connection=[keep-alive], Content-Length=[0], Date=[Tue, 12 Mar 2019 14:53:22 GMT]}, responseCode=200, status='OK', protocol=HTTP/1.1} for request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,055 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:103> response terminated for request to localhost/127.0.0.1:7777 /
07:54:52,055 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientConnection] <HttpClientConnection.java:479> exchange complete in connection to localhost/127.0.0.1:7777
07:54:52,055 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,055 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:566> Sent request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target 127.0.0.1 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,056 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:87> request terminated for request to localhost/127.0.0.1:7777 /
07:54:52,056 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:691> Received response ClientResponse{responseHeaders={Connection=[keep-alive], Content-Length=[0], Date=[Tue, 12 Mar 2019 14:53:22 GMT]}, responseCode=200, status='OK', protocol=HTTP/1.1} for request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}
07:54:52,056 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientExchange] <HttpClientExchange.java:103> response terminated for request to localhost/127.0.0.1:7777 /
07:54:52,056 DEBUG (XNIO-186 I/O-1) [io.undertow.client.http.HttpClientConnection] <HttpClientConnection.java:479> exchange complete in connection to localhost/127.0.0.1:7777
07:54:52,057 DEBUG (XNIO-186 I/O-1) [io.undertow.server.handlers.proxy] <ProxyHandler.java:549> Sending request ClientRequest{path='/', method=GET, protocol=HTTP/1.1} to target localhost/127.0.0.1:7777 for exchange HttpServerExchange{ GET / request {Connection=[Keep-Alive], User-Agent=[Apache-HttpClient/4.5.6 (Java/1.8.0_152)], Host=[localhost:7778]} response {}}

@fl4via
Copy link
Member

fl4via commented Apr 1, 2019

Retest this please

fl4via
fl4via requested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@fl4via fl4via left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please include [UNDERTOW-1519] in the commit message? Thanks

@fl4via
Copy link
Member

fl4via commented Apr 1, 2019

I created a JIra for this issue: https://issues.jboss.org/browse/UNDERTOW-1504

@fl4via
Copy link
Member

fl4via commented Apr 1, 2019

Sorry, wrong Jira: https://issues.jboss.org/browse/UNDERTOW-1519

@fl4via
Copy link
Member

fl4via commented Apr 2, 2019

Retest this please

@fl4via fl4via merged commit 9cb9771 into undertow-io:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl4via fl4via fl4via requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@smironov @undertow-pull-request @colesico @ctomc @fl4via