UNDERTOW-1550 Make undertow build fine on JDK11 #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he jboss-parent pom Relates to https://issues.apache.org/jira/browse/FELIX-5592
|
This is ok to test |
fl4via
approved these changes
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit here fixes the issue reported in https://issues.jboss.org/browse/UNDERTOW-1550 letting the
jboss-parentpom dictate the version ofmaven-bundle-plugin. Thejboss-parentpom version35correctly uses a version ofmaven-bundle-pluginwhich understands Java 9+ multi-release jars and allows builds to pass on JDK11.P.S: With this change, the build works fine with both JDK 8 and 11.