UNDERTOW-1565 Don't encode query strings and URI paths while redirecting #785
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit here fixes the issue reported in https://issues.jboss.org/browse/UNDERTOW-1565
The code in
SinglePortConfidentialityHandler
which deals with forming the redirect URI was using the 7 argument constructor ofjava.net.URI
, which as per its javadoc, internally encodes the passed parameters, like thequeryString
. We do not want that to happen, since the query string and other components of the URI that we are building aren't expected to be decoded/encoded, by the container, while we are building the redirect URI.The commit here uses a
StringBuilder
to form the redirect URI and then passes it to the single argument constructor ofjava.net.URI
which doesn't do the encoding of the passed parameter, unlike the 7 argument constructor.The commit also includes an update to an existing testcase to reproduce the issue and verify the fix.