[UNDERTOW-1618][UNDERTOW-1619][UNDERTOW-1620] Fix issues with abstract framed channels #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fl4via
changed the title
|
This is ok to test |
carterkozak
reviewed
Nov 27, 2019
| while (allAreSet(state, STATE_READS_RESUMED) && allAreClear(state, STATE_CLOSED | STATE_STREAM_BROKEN) && moreData); | ||
| } finally { | ||
| } while (readAgain); | ||
| } catch (RuntimeException e) { |
There was a problem hiding this comment.
We might want to be cautious here and handle errors just in case.
Suggested change
| } catch (RuntimeException e) { | |
| } catch (RuntimeException | Error e) { |
There was a problem hiding this comment.
+1, I'll incorporate this change
carterkozak
reviewed
Nov 27, 2019
| taskRunQueue.poll().run(); | ||
| Runnable runnable; | ||
| while ((runnable = taskRunQueue.poll()) != null) { | ||
| runnable.run(); |
There was a problem hiding this comment.
Looks like there's one more instance of this pattern on newFrames in void flushSenders()
There was a problem hiding this comment.
Good catch! I created https://issues.jboss.org/browse/UNDERTOW-1621 and I'll add a fix for this in this PR.
…_AWAKEN state, and synchronize read internal task in a way to prevent a wakeupReads() call being ignored in specific race condition scenarios
…STATE_CLOSED at AbstractFramedStreamSourceChannel.lastFrame
…ints that run taskRunQueue if they run concurrently
…en polling newFrames
fl4via
force-pushed
the
UNDERTOW-1618
branch
from
cb74b76
to
fc3ef4e
Compare
fl4via
added
next release
fl4via
removed
waiting CI check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jiras: https://issues.jboss.org/browse/UNDERTOW-1618
https://issues.jboss.org/browse/UNDERTOW-1619
https://issues.jboss.org/browse/UNDERTOW-1620
https://issues.jboss.org/browse/UNDERTOW-1621