Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1699] Remove unused private fields from Http2ReceiveListener #861

Merged
merged 1 commit into from Apr 17, 2020
Merged

[UNDERTOW-1699] Remove unused private fields from Http2ReceiveListener #861

merged 1 commit into from Apr 17, 2020

Conversation

carterkozak
Copy link
Contributor

No description provided.

@fl4via fl4via added the under verification Currently being verified (running tests, reviewing) before posting a review to contributor label Mar 10, 2020
fl4via
fl4via approved these changes Apr 17, 2020
View reviewed changes
Copy link
Member

@fl4via fl4via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add this to 2.1.0.Final, I'll be creating a Jira and updating the PR within the next minutes

@fl4via fl4via added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) waiting CI check Ready to be merged but waiting for CI check and removed under verification Currently being verified (running tests, reviewing) before posting a review to contributor labels Apr 17, 2020
@fl4via fl4via force-pushed the ckozak/Http2ReceiveListener_unused_fields branch from 9322b11 to 605c95d Compare April 17, 2020 10:20
@fl4via fl4via changed the title Remove unused private fields from Http2ReceiveListener [UNDERTOW-1699] Remove unused private fields from Http2ReceiveListener Apr 17, 2020
@fl4via
Copy link
Member

fl4via commented Apr 17, 2020

This is ok to test

@fl4via fl4via removed the waiting CI check Ready to be merged but waiting for CI check label Apr 17, 2020
@fl4via fl4via merged commit c265de6 into undertow-io:master Apr 17, 2020
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl4via fl4via fl4via approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code
Projects
None yet
Milestone
No milestone
2 participants
@carterkozak @fl4via