Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UNDERTOW-1700: Prevent resource leaks when exchanges aren't closed cleanly #866

Merged
merged 1 commit into from Apr 17, 2020
Merged

UNDERTOW-1700: Prevent resource leaks when exchanges aren't closed cleanly #866

merged 1 commit into from Apr 17, 2020

Conversation

carterkozak
Copy link
Contributor

This does not solve the linked ticket, but prevents the described
scenario from causing additional problems.

While the modified blocks are commented suggesting that they
should never be called, UNDERTOW-1664 describes when they occur
with a reproducer.

@fl4via fl4via changed the title UNDERTOW-1664: Prevent resource leaks when exchanges aren't closed cleanly UNDERTOW-1700: Prevent resource leaks when exchanges aren't closed cleanly Apr 17, 2020
@carterkozak @fl4via
UNDERTOW-1700: Prevent resource leaks when exchanges aren't closed cl…
aab57fa 
…eanly

This does not solve the linked ticket, but prevents the described
scenario from causing additional problems.

While the modified blocks are commented suggesting that they
should never be called, UNDERTOW-1664 describes when they occur
with a reproducer.
@fl4via fl4via force-pushed the ckozak/completion_listener_leak branch from 0cac9ba to aab57fa Compare April 17, 2020 10:33
@fl4via
Copy link
Member

fl4via commented Apr 17, 2020

This is ok to test

@fl4via fl4via added enhancement Enhances existing behaviour or code next release This PR will be merged before next release or has already been merged (for payload double check) waiting CI check Ready to be merged but waiting for CI check and removed waiting CI check Ready to be merged but waiting for CI check labels Apr 17, 2020
@fl4via fl4via merged commit 710e6af into undertow-io:master Apr 17, 2020
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl4via fl4via fl4via approved these changes

Assignees
No one assigned
Labels
enhancement Enhances existing behaviour or code
Projects
None yet
Milestone
No milestone
2 participants
@carterkozak @fl4via