UNDERTOW-1773 to avoid potential leak, make sure the iteration continue in case of exception. #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.<HttpSessionListener> get(listener).sessionDestroyed(sre); | ||
| } catch (Exception e) { | ||
| // UNDERTOW-1773 to avoid leak, make sure the iteration continue in case of exception. | ||
| UndertowLogger.ROOT_LOGGER.debugf(e, "Exception happens in sessionDestroyed for session %s ", session); |
There was a problem hiding this comment.
This should really be at error level.
There was a problem hiding this comment.
Thank you, I have updated the log level to ERROR
soul2zimate
force-pushed
the
UNDERTOW-1773-master
branch
2 times, most recently
from
512c200
to
90d5600
Compare
|
As has been discussed in the JBEAP Jira, we should apply the same fix to other listener notifications as well. |
OK, I will apply them to all other listener notifications. |
soul2zimate
force-pushed
the
UNDERTOW-1773-master
branch
from
90d5600
to
3d4649a
Compare
|
I have updated the commit to cover all other methods with listener invocations |
fl4via
added
bug fix
fl4via
approved these changes
Sep 13, 2020
This was referenced Sep 14, 2020
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://issues.redhat.com/browse/UNDERTOW-1773
UNDERTOW-1773 to avoid potential leak, make sure the iteration continue in case of exception.