[UNDERTOW-1802] Improve FormEncodedDataDefinition to handle chars in configured encoding #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…configured encoding
rmartinc
force-pushed
the
UNDERTOW-1802-master
branch
from
9cff77f
to
fbad2b6
Compare
rmartinc
changed the title
fl4via
added
bug fix
fl4via
approved these changes
Dec 3, 2020
This was referenced Dec 3, 2020
Merged
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/UNDERTOW-1802
The FormEncodedDataParser has been modified to also perform a decode if a non-ascii (n < 0) character is found. The URLUtils.decode method was already prepared to handle those bytes.
The test now uses the payload instead of the headers to return the data (because now strange chars can be returned). Finally a method that sends direct UTF-8 characters is added to include a test for this specific use-case.
PR for master branch.
2.1.x PR: #979
2.0.x PR: #978