UNDERTOW-1791: Migrate from getPeerCertificateChain to getPeerCertificates #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
force-pushed
the
ckozak/UNDERTOW-1791
branch
from
f7d0ca9
to
9dc94c9
Compare
carterkozak
force-pushed
the
ckozak/UNDERTOW-1791
branch
from
9dc94c9
to
7f8c3c1
Compare
ropalka
added
bug fix
ropalka
requested changes
Nov 25, 2020
...et/src/main/java/io/undertow/servlet/handlers/security/SSLInformationAssociationHandler.java
Outdated
Show resolved
Hide resolved
carterkozak
force-pushed
the
ckozak/UNDERTOW-1791
branch
from
7f8c3c1
to
e97ddae
Compare
ropalka
approved these changes
Nov 25, 2020
|
this PR introduced a regression in the SSL tests and will require some investigation before being merged |
fl4via
removed
the
next release
…cates On java 15 runtimes the default jsse SSLSession implementation throws an UnsupportedOperationException when getPeerCertificateChain is called. https://www.oracle.com/java/technologies/javase/15-relnote-issues.html#JDK-8241039
carterkozak
force-pushed
the
ckozak/UNDERTOW-1791
branch
from
e97ddae
to
0bb82d2
Compare
|
I've fixed the failure -- sorry about that. Hopefully it's not too late for 2.2.3.Final. |
|
thanks, there is still time for 2.2.3.Final @carterkozak ! |
fl4via
added
next release
fl4via
removed
the
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/UNDERTOW-1791
Java 15 runtimes default jsse SSLSession implementation throws an
UnsupportedOperationException when getPeerCertificateChain is called.
https://www.oracle.com/java/technologies/javase/15-relnote-issues.html#JDK-8241039
In this PR I have replaced uses of getPeerCertificateChain with getPeerCertificates, however I have not provided an implementation of sslsessioninfo.getPeerCertificateChain which delegates to getPeerCertificates and converts to the javax variant. It's unclear if that would be desirable.
It appears unlikely that there are cases in which getPeerCertificates produces different results, but it's possible a SSLSession implementation is incorrect in a way that causes this change to introduce failures. We could flag this behavior behind a property.