Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Parser.js to handle new Item Class line #19

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

r-last
Copy link

@r-last r-last commented Apr 21, 2021

Modified Parser.js to handle new Item Class line added by GGG in POE 3.14

Thanks to @AdVurt for his much more elegant suggestion to solving the problem.

@Odzinic
Copy link

Odzinic commented Apr 22, 2021

Just curious, what did you build this on? I can't seem to get the AppImage for your PR or the master to build at all on Linux.

@r-last
Copy link
Author

r-last commented Apr 22, 2021

Just curious, what did you build this on? I can't seem to get the AppImage for your PR or the master to build at all on Linux.

I built this on Windows although I suspect my machine is a little funky. It did take both a npm install and npm audit fix to get the base code to start before I started working on the code. I only included the javascript changes in the pull as the simple change of one js file should not affect the build process.

@Anupalabdhi
Copy link

Anupalabdhi commented Apr 25, 2021

Just to follow up on @Odzinic's point (at the risk of going slightly off-topic from this PR), I tried building the original undg's master and r-last's master on linux, but npm kept erroring out in the 'npm install' phase. Now, I am not the technical type, but from what I could gather, it was cranking out on account of the node module "ref" which as I found out hasn't been updated in a while. I tried manually installing ref through npm, and the command moved forward but it threw up audit warnings about vulnerabilities while doing npm install. The dependencies seem to be in a deprecated mess.

@roerch
Copy link

roerch commented May 14, 2021

Finally managed to build it myself on Linux, but I had to use the --no-audit option of 'npm install', since the audit would replace electron to a new version, which in turn depends on a new version of nodejs itself and for somewhat reason this project doesn't go well with node > v8. It appears that quite some effort would be needed to upgrade this project to the most recent versions of each software package.
EDIT: Just as a follow-up. The changes to the clipboard contents seem to be larger than "just adding a row". Currencies do work, Uniques, Maps, etc. don't.

@undg undg merged commit 224c359 into undg:master Jun 15, 2021
@undg
Copy link
Owner

undg commented Jun 23, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants