-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We need a better docker image #908
Comments
More information:Meteor guide on how to deploy with Docker. To orchestrate your own container-based deployment there are existing base images to consider before rolling your own:
The disney/meteor-base looks promising... |
Since we are running on Meteor 1.8.1, we probably need to look at https://github.com/disney/meteor-base/tree/2572c3acf0b5c02971a78887905aa99f84f01672 |
I used https://github.com/CyCoreSystems/go-meteor at #750 (comment) which is now the basis of the current (working) https://github.com/unee-t/frontend/blob/master/Dockerfile I'm not a 100% sure you can bootstrap meteor without node. |
Btw I think I said it elsewhere, but I don't think it's absolutely necessary to do Tests imo should be run in the CI phase (travis?) We should only be building the Docker image if the tests pass, but that's not the case atm since Travis and CodeBuild are disjoint. |
The Docker image we are building in the current version of the master is based on an image for a node.js application.
We are building the Unee-T frontend with Meteor which includes pre-packaged and compatible versions of nmp and node js.
As seen in issue #901 the node based image is most likely the reason why we have issues running the tests.
We need a simple image for Unee-T which shall include:
Anything else is most likely overkill and will propably cause unnecessary conflicts.
The text was updated successfully, but these errors were encountered: