Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case pin on floor plan #874

Merged
merged 5 commits into from
Sep 13, 2019
Merged

Conversation

nbiton
Copy link
Contributor

@nbiton nbiton commented Sep 8, 2019

Partially addresses #855

This PR includes the creation of pins on an existing floor plan in the case creation view, and display of the floor plan with pins in the case messages view.

Functionality not included in this PR which will be implemented separately:

  • Detailed display of the latest floor plan pins position (for a case) in the case details view.
  • Editing of floor plan pins.
  • Addition of a missing unit floor plan from case views.

@nbiton nbiton temporarily deployed to unee-t-pr-874 September 8, 2019 21:42 Inactive
@nbiton nbiton added the wip Work In Progress label Sep 8, 2019
@franck-boullier
Copy link
Member

franck-boullier commented Sep 9, 2019

Tests Done:

Test that went OK:

  • Logged in as Nath
  • go to a unit with a floor plan (10 LG) - PASSED
  • Create a new case
  • I see the floor plan - PASSED
  • I can add one pin - PASSED
  • I can remove the pin - PASSED
  • I can add more pins - PASSED
  • I can zoom in on the floor Plan - PASSED
  • I save the case - PASSED

Tests that failed:

  • After the case is saved/created I can see the floor plan in the conversation - FAILED
  • After the case is saved/created I can see the floor plan in the "More Information" tab - FAILED/NOT AVAILABLE
  • If there is no "location on the floor plan" info for a case I can add the location on the floor plan to the case in the "More Information" tab - FAILED/NOT AVAILABLE

Unable to test:

  • Move the pin on a floor plan for a case
  • If there is no "location on the floor plan" info for a case I can add the location on the floor plan to the case.

@franck-boullier
Copy link
Member

franck-boullier commented Sep 12, 2019

The test done:

Test that went OK:

  • Logged in as Nath
  • go to a unit with a floor plan (10 LG) - PASSED
  • Create a new case
  • I see the floor plan - PASSED
  • I can add one pin - PASSED
  • I can remove the pin - PASSED
  • I can add more pins - PASSED
  • I save the case - PASSED
  • After the case is saved/created I can see the floor plan in the conversation - PASSED

Tests that failed:

  • While I'm creating the case, I can zoom in on the floor Plan to place a pin on a specific area on the plan - FAILED After I zoom in on the floor plan it is NOT possible to move the image around. Some part of the floor plan are NOT visible when the floor plan is zoomed in.
  • I can see zoom in on the floor plan in the case the conversation - FAILED
  • After the case is saved/created I can see the floor plan in the "More Information" tab - FAILED/NOT AVAILABLE
  • If there is no "location on the floor plan" info for a case I can add the location on the floor plan to the case in the "More Information" tab - FAILED/NOT AVAILABLE

Unable to test:

  • Move the pin on a floor plan for a case
  • If there is no "location on the floor plan" info for a case I can add the location on the floor plan to the case.

@nbiton
Copy link
Contributor Author

nbiton commented Sep 12, 2019

Move the pin on a floor plan for a case

@franck-boullier Why would you need to move a pin, if you can just remove the previous and add a new one?

After I zoom in on the floor plan it is NOT possible to move the image around. Some part of the floor plan are NOT visible when the floor plan is zoomed in

I don't understand what this means

I can see zoom in on the floor plan in the case the conversation

I'm not sure I understand exactly what this means, but the floor plan on the messages view is currently designed to be static. The user won't be able to zoom in on the floor plan in the message view

@nbiton nbiton removed the wip Work In Progress label Sep 13, 2019
@nbiton nbiton changed the title WIP: Case pin on floor plan Case pin on floor plan Sep 13, 2019
@nbiton
Copy link
Contributor Author

nbiton commented Sep 13, 2019

This PR should be ready to merge now

@franck-boullier
Copy link
Member

Basic functionalities tested and OK:

Logged in as Nath

  • go to a unit with a floor plan (10 LG) - PASSED
  • Create a new case
  • I see the floor plan - PASSED
  • I can add one pin - PASSED
  • I can remove the pin - PASSED
  • I can add more pins - PASSED
  • I save the case - PASSED
  • After the case is saved/created I can see the floor plan in the conversation - PASSED

The following functionalities will come in a separate PR:

  • I can zoom in on the floor plan in the case the conversation
  • After the case is saved/created I can see the floor plan in the "More Information" tab
  • If there is no "location on the floor plan" info for a case I can add the location on the floor plan to the case in the "More Information" tab
  • Move the pin on a floor plan for a case
  • If there is no floor plan for that unit, I can add the floor plan directly from the case.

@franck-boullier franck-boullier merged commit 26878fa into unee-t:master Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants