Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow signup with promo codes #888

Merged
merged 2 commits into from
Oct 16, 2019
Merged

feat: allow signup with promo codes #888

merged 2 commits into from
Oct 16, 2019

Conversation

nbiton
Copy link
Contributor

@nbiton nbiton commented Oct 16, 2019

image

@nbiton nbiton temporarily deployed to unee-t-pr-888 October 16, 2019 05:42 Inactive
@nbiton
Copy link
Contributor Author

nbiton commented Oct 16, 2019

@franck-boullier I created two promo codes on the review app DB, for you to test:
"promo-code" (Works)
"expired" (Expired)

@franck-boullier
Copy link
Member

promo code is case sensitive.
This is an inconvenience because some user will type the promo code instead of copy/pasting it.

Since Android automatically capitalize the 1st letter of any line, the promo code is displayed as invalid.

Possible solution: is it difficult to make the promo code case insensitive?

@nbiton
Copy link
Contributor Author

nbiton commented Oct 16, 2019

Should be easy... checking now

@nbiton
Copy link
Contributor Author

nbiton commented Oct 16, 2019

The last commit should fix it

@franck-boullier franck-boullier merged commit b9307ec into unee-t:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franck-boullier franck-boullier Awaiting requested review from franck-boullier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nbiton @franck-boullier