Use gh pages (Major) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
approved these changes
Oct 30, 2018
bin/deploy-site
Outdated
| process.exit(1); | ||
| } | ||
|
|
||
| const scripts = JSON.parse(fs.readFileSync(packageJson, 'utf-8')).scripts |
There was a problem hiding this comment.
Missing semicolon at EOL.
Could be simplified a bit with findup-sync:
const findUpSync = require('findup-sync');
const packageJson = findUpSync('package.json');
if (!packageJson) {
console.error('Please run in the root directory of the package');
process.exit(1);
}
const scripts = require(packageJson).scripts;... That also wouldn't require the cwd to be the root of the repository. Especially not if you go:
childProcess.execSync('npm run generate-site', {cwd: path.dirname(packageJson)})There was a problem hiding this comment.
Nice - I'll try that.
There was a problem hiding this comment.
Mhh the gh-pages also needs to run from the root. I think I'll just leave it simple as it is.
sunesimonsen
force-pushed
the
ssimonsen/use-gh-pages
branch
from
60e2505
to
5fd784f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current deploy-site script with one based on gh-pages. I have removed the unused TARGET_BRANCH capabilities.
Tested on chance-generators