Merge 9424b6b into 7bc7c8a

unexpectedjs · Nov 25, 2019 · 38dfeac · 38dfeac
2 parents 7bc7c8a + 9424b6b
commit 38dfeac
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -286,7 +286,7 @@ module.exports = {
         );
       },
       equal(a, b) {
-        return a.nodeValue === b.nodeValue;
+        return a.nodeType === b.nodeType && a.nodeValue === b.nodeValue;
       },
       inspect(element, depth, output) {
         return output.code(

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -1678,6 +1678,27 @@ describe('unexpected-dom', () => {
         `
         );
       });
+
+      describe('on nodes of different types', () => {
+        it('should fail', () => {
+          expect(() => {
+            expect(
+              parseHtmlNode(
+                '<ul><li>John</li><li class="winner">Jane</li><li>Annie</li></ul>'
+              ),
+              'to equal',
+              parseHtmlDocument(
+                '<!DOCTYPE html><html><body><h1>Tournament</h1><ul><li>John</li><li>Jane</li><li class="winner">Annie</li></ul></body></html>'
+              )
+            );
+          }, 'to throw an error satisfying to equal snapshot', expect.unindent`
+            expected <ul><li>John</li><li class="winner">Jane</li><li>Annie</li></ul>
+            to equal <!DOCTYPE html><html><head></head><body>...</body></html>
+
+            Mismatching constructors HTMLUListElement should be Document
+          `);
+        });
+      });
     });
 
     describe('on text nodes', () => {