Guard against empty style properties as a result of trailing semicolo…

…ns in inline style attributes. Fixes #19
unexpectedjs · May 31, 2015 · 43db5bc · 43db5bc
1 parent 65d0846
commit 43db5bc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -27,7 +27,10 @@ function styleStringToObject(str) {
   str.split(';').forEach(function (rule) {
     var tuple = rule.split(':').map(function (part) { return part.trim(); });
 
-    styles[tuple[0]] = tuple[1];
+    // Guard against empty touples
+    if (tuple[0] && tuple[1]) {
+      styles[tuple[0]] = tuple[1];
+    }
   });
 
   return styles;

diff --git a/test/unexpected-dom.js b/test/unexpected-dom.js
@@ -586,6 +586,16 @@ describe('unexpected-dom', function () {
               });
             }, 'to throw', /to have attributes \{ style: \{ background: 'blue' \} \}/);
           });
+
+          it('should handle trailing semicolon', function () {
+            this.body.innerHTML = '<div style="color: red;"></div>';
+
+            expect(this.body.firstChild, 'to only have attributes', {
+              style: {
+                color: 'red'
+              }
+            });
+          });
         });
 
         describe('strict comparison', function () {