Compare the node type when comparing DOM nodes for equality

unexpectedjs · Nov 25, 2019 · 9e2ab35 · 9e2ab35
1 parent 9250b25
commit 9e2ab35
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 12 deletions.
diff --git a/src/index.js b/src/index.js
@@ -286,7 +286,7 @@ module.exports = {
         );
       },
       equal(a, b) {
-        return a.nodeValue === b.nodeValue;
+        return a.nodeType === b.nodeType && a.nodeValue === b.nodeValue;
       },
       inspect(element, depth, output) {
         return output.code(

diff --git a/test/index.spec.js b/test/index.spec.js
@@ -1681,17 +1681,26 @@ describe('unexpected-dom', () => {
 
       describe('on nodes of different types', () => {
         it('should fail', () => {
-          expect(() => {
-            expect(
-              parseHtmlNode(
-                '<ul><li>John</li><li class="winner">Jane</li><li>Annie</li></ul>'
-              ),
-              'to equal',
-              parseHtmlDocument(
-                '<!DOCTYPE html><html><body><h1>Tournament</h1><ul><li>John</li><li>Jane</li><li class="winner">Annie</li></ul></body></html>'
-              )
-            );
-          }, 'to throw');
+          expect(
+            () => {
+              expect(
+                parseHtmlNode(
+                  '<ul><li>John</li><li class="winner">Jane</li><li>Annie</li></ul>'
+                ),
+                'to equal',
+                parseHtmlDocument(
+                  '<!DOCTYPE html><html><body><h1>Tournament</h1><ul><li>John</li><li>Jane</li><li class="winner">Annie</li></ul></body></html>'
+                )
+              );
+            },
+            'to throw an error satisfying to equal snapshot',
+            expect.unindent`
+            expected <ul><li>John</li><li class="winner">Jane</li><li>Annie</li></ul>
+            to equal <!DOCTYPE html><html><head></head><body>...</body></html>
+
+            Mismatching constructors HTMLUListElement should be Document
+          `
+          );
         });
       });
     });