Model <!--ignore--> as its own type and implement the ignoring via an assertion

[papandreou]

Fixes <!--ignore--> as the top-level to satisfy RHS.

[coveralls]

Pull Request Test Coverage Report for Build 820

• 7 of 8 (87.5%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.1%) to 91.499%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/index.js	7	8	87.5%

Totals
Change from base Build 814:	-0.1%
Covered Lines:	525
Relevant Lines:	555

---

💛 - Coveralls

[alexjeffburke]

This is an incredibly elegant solution given the mechanisms available in Unexpected. The modelling of the types in these assertions are such a glove for the DOM that I get this in concept but only just in details.

[sunesimonsen]

@papandreou this is brilliant and how I should have made it in the first place - thanks 👍

[sunesimonsen]

I'll merge this as @alexjeffburke okayed it.

[papandreou]

Great! I wonder if the same idea can be used for <ignore>

[sunesimonsen]

Yes that would make sense.

[sunesimonsen]

You can probably just add the new type to all of the ignore assertions you added.

[sunesimonsen]

@papandreou

Great! I wonder if the same idea can be used for

I actually think we should remove the custom element ignore again. It is not documented and can't be used from unexpected-reaction. It doesn't have an element prefix, so it is not a real custom tag, and I prefer to just have one way. Would that be okay with you?

[alexjeffburke]

@sunesimonsen I'd like to second you on this one - I think the rationale is solid and, for example, knockout now bans such tag definitions for custom elements outright to avoid problems with them which might be a useful datapoint.