Browser tests #246
Merged
Browser tests #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papandreou
reviewed
Jan 6, 2019
Pull Request Test Coverage Report for Build 968
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 968
💛 - Coveralls |
Pull Request Test Coverage Report for Build 972
💛 - Coveralls |
This test appears to have pre-existing problems but endure it works. It appears however that it cannot function in the browser because the DOMImplementation property cannot be overridden - thus skip it in that environment.
Rearrange things to have only a single copy of common node glue. Note that there is an issue somewhere around overwriting the preferred output width which we sidestep by arranging the various test targets to run in separate processes.
alexjeffburke
force-pushed
the
feature/browser-tests
branch
from
2508b99
to
61a6e1c
Compare
|
This is really great! We should setup the test matrix like unexpected, there is no reason to run the browser tests for all Node versions. But I can help with that if you want me too. I also want to run this on BrowserStack in IE11, but I can make a separate PR for that as this is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the test suite to the browser and adds a karma based headless setup.